Fix bug in LastOrDefault for extrema sequence #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
==========================================
+ Coverage 88.55% 88.90% +0.34%
==========================================
Files 106 106
Lines 3487 3487
Branches 978 978
==========================================
+ Hits 3088 3100 +12
+ Misses 258 250 -8
+ Partials 141 137 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug reported in #760.
Note that the tests added in 86f6f58 were testing
First,FirstOrDefault,LastandLastOrDefaultmembers ofSystem.Linq.Enumerablerather than those from MoreLINQ that extendIExtremaEnumerable<>. This PR fixes that too. In fact, the bug only surfaced after realising that 86f6f58 wasn't testing the right implementation.